Skip to content

Chore | Update hcl parsing library #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angelofenoglio merged 4 commits into from
Aug 11, 2025
Merged

Chore | Update hcl parsing library #309

angelofenoglio merged 4 commits into from
Aug 11, 2025

Conversation

@angelofenoglio
Copy link
Contributor

@angelofenoglio angelofenoglio commented Jul 29, 2025 •
edited by coderabbitai bot
Loading

What?

  • Update python-hcl2 parsing library to 3.7.1

Why?

  • To better handle HCL syntax

Summary by CodeRabbit

  • Chores
    • Updated the version of an internal dependency to improve compatibility and stability.
    • Corrected integration test configurations and fixed a command typo to ensure smoother test execution.

@angelofenoglio angelofenoglio self-assigned this Jul 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 29, 2025 •
edited
Loading

Walkthrough

The version of the python-hcl2 dependency in the pyproject.toml file was updated from 7.0.1 to 7.3.1. Additionally, the integration test workflow matrix was updated to newer toolbox-image-tag versions, and a typo in the Terraform initialization command was corrected.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
pyproject.toml		 Updated python-hcl2 version from 7.0.1 to 7.3.1
CI Workflow Updates
.github/workflows/tests-integration.yaml		 Updated toolbox-image-tag matrix versions and fixed a typo in the Terraform init command from leverage tf init to leverage terraform init

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

minor, enhancement

Suggested reviewers

  • diego-ojeda-binbash

Poem

A hop and a skip, a version anew,
HCL2’s number just grew!
From seven-point-oh-one to three-one,
Dependency updates—oh what fun!
Toolbox tags fresh, commands now right,
The rabbit hops on through the night! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69f5c6a and 659f108.

📒 Files selected for processing (1)
  • .github/workflows/tests-integration.yaml (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/tests-integration.yaml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-python-hcl-library

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coveralls
Copy link

coveralls commented Jul 29, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16607256507

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.138%
Totals Coverage Status
Change from base Build 15832450392: 0.0%
Covered Lines: 2606
Relevant Lines: 4130
💛 - Coveralls

diego-ojeda-binbash
diego-ojeda-binbash approved these changes Jul 31, 2025
View reviewed changes
.github/workflows/tests-integration.yaml
printf "[INFO] Initializing layer\n"
leverage tf init --skip-validation
leverage terraform init --skip-validation
Copy link
Collaborator

@diego-ojeda-binbash diego-ojeda-binbash Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelofenoglio Shouldn't we use tofu instead of terraform here?

Copy link
Contributor Author

@angelofenoglio angelofenoglio Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to deprecate all currently tested images, (see L29 on this file).
It would require a little more refactoring here that I want to tackle in a later PR

Copy link
Contributor Author

@angelofenoglio angelofenoglio Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather go with some conditional logic or something of the sort.

@angelofenoglio angelofenoglio merged commit 3fc4eec into master Aug 11, 2025
20 of 32 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 11, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Aug 26, 2025
Merged
@angelofenoglio angelofenoglio deleted the chore/upgrade-python-hcl-library branch September 19, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diego-ojeda-binbash diego-ojeda-binbash diego-ojeda-binbash approved these changes

@Franr Franr Awaiting requested review from Franr

Assignees

@angelofenoglio angelofenoglio

Labels

fix patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@angelofenoglio @coveralls @diego-ojeda-binbash @exequielrafaela